isl_basic_set_compute_vertices: add sanity check on full-dimensionality

The computation in compute_chambers assumes that the projection
of the entire parametric polytope onto the parameter space
is full-dimensional.  The function can_intersect already checks
that the activity domains of the vertices are full-dimensional,
but if the entire projection is not full-dimensional, then no vertices
get added in the first place because their activity domains
are not full-dimensional.
Note that even though isl_basic_set_compute_vertices already handles
equality constraints that are explicitly available, it fails
to handle implicit equality constraints.
This means that the sanity check may fail in some cases,
but this is already an improvement over running into an infinite loop.
The failure itself will be handled in upcoming commits.

Signed-off-by: Sven Verdoolaege <sven.verdoolaege@gmail.com>

isl_vertices.c

@@ -862,6 +862,7 @@ static __isl_give isl_vertices *compute_chambers(__isl_take isl_basic_set *bset,
 {
 	int i;
 	isl_ctx *ctx;
+	isl_size n_eq;
 	isl_vec *sample = NULL;
 	struct isl_tab *tab = NULL;
 	struct isl_tab_undo *snap;
@@ -879,6 +880,12 @@ static __isl_give isl_vertices *compute_chambers(__isl_take isl_basic_set *bset,
 		goto error;
 
 	bset = isl_basic_set_params(bset);
+	n_eq = isl_basic_set_n_equality(bset);
+	if (n_eq < 0)
+		goto error;
+	if (n_eq > 0)
+		isl_die(isl_basic_set_get_ctx(bset), isl_error_internal,
+			"expecting full-dimensional input", goto error);
 
 	tab = isl_tab_from_basic_set(bset, 1);
 	if (!tab)